Fix never forget cooldown seconds in checkCooldownAndRemoveIfExpired.

mikebronner / laravel-model-caching

Eloquent model-caching made easy.

MIT License

2.26k stars 217 forks source link

Fix never forget cooldown seconds in checkCooldownAndRemoveIfExpired. #211

Closed imunew closed 5 years ago

imunew commented 5 years ago

I execute ${cachableModel}->scopeWithCacheCooldownSeconds. But cooldown seconds never been changed. So, I found this problem in Caching::checkCooldownAndRemoveIfExpired. (Maybe copy and paste code but not changed from cooldown:invalidated-at to cooldown:seconds ?)

mikebronner commented 5 years ago

Thanks for posting a possible solution! :) I will take a look at this, hopefully this weekend. I'm pretty swamped at the moment with another project, so can't make any concrete promises.

imunew commented 5 years ago

@mikebronner Can you review this PR in this week?

mikebronner commented 5 years ago

I will try. I am currently working on Laravel 5.8 compatibility and will review the PRs after that.

mikebronner commented 5 years ago

yea, that was a copy/paste issue, thanks for finding that!