Add Laravel 5.8 Compatibility

mikebronner / laravel-model-caching

Eloquent model-caching made easy.

MIT License

2.26k stars 217 forks source link

Add Laravel 5.8 Compatibility #215

Closed mikebronner closed 5 years ago

dmason30 commented 5 years ago

@mikebronner Since this contained breaking changes, namely the backwards compatibility shouldn't this have been a major release (1.0.0) not minor (0.4.0)? Considering most will have this installed as ^0.3.6 etc

mikebronner commented 5 years ago

@dmason30, no ... 0.x releases are breaking changes during the beta phase. 1.0.0 release would be the initial go-live. It is still in beta. I guess an argument could be made that since so many people are relying on it, it should no longer be in beta? I don't quite feel comfortable yet with that, as we are still ironing out quite a few edge-cases.