search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.26k stars 217 forks source link

Laravel 5.8 constraint doesn't allow composer to pull >5.8.0 #216

Closed Phr33d0m closed 5 years ago

Phr33d0m commented 5 years ago

Hi, as the title says. I was wondering why my composer update didn't pull the already available 5.8.2 release thus I ran:

$ composer prohibits laravel/framework:5.8.2
genealabs/laravel-model-caching  0.4.1  requires  illuminate/support (5.8)

Could you relax the requirement a bit? Something like 5.8.* should be correct.

Thanks.

mikebronner commented 5 years ago

@Phr33d0m haha, for sure!! sorry about that ... I was using the range specification before, where the patch version didn't matter. Fix coming up in a sec.

Phr33d0m commented 5 years ago

@mikebronner Thanks!

Btw, I know this is a different issue but as I have your attention in here could you fix this as well for the next version bump?

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - genealabs/laravel-model-caching 0.4.5 requires fico7489/laravel-pivot dev-patch-1@dev -> no matching package found.

I'm not a composer guru so I have no idea why it's not picking up the custom repository...

mikebronner commented 5 years ago

hmmmm, It should be pulling from my fork on GitHub ... I'll look into it some more: https://github.com/mikebronner/laravel-pivot

mikebronner commented 5 years ago

I'm not able to replicate the problem, it downloads the patch for me everytime I try, even after clearing composer cache. Would you mind pasting your composer.json here for me to take a look at?

Phr33d0m commented 5 years ago

For me the error is reproducible every time. Just do laravel new testrepo && cd testrepo && composer require genealabs/laravel-model-caching and it should fail.

mikebronner commented 5 years ago

@Phr33d0m This should now work in version 0.4.7.