Closed Hornet-Wing closed 4 years ago
@Hornet-Wing Thanks for this! I will try to get to it this weekend. :)
No problem, there are a couple of other things I noticed. For example, the PaginationTest specifically looks for 6.0 version but with Laravel following semver it wont be possible to follow it like this (we're already at 6.2).
@Hornet-Wing yea, I'll get all those things addressed when I get all tests to green.
Again, I'm happy to lend a hand if you'd like! Now that I've got the tests running locally, it won't be too much work.
@Hornet-Wing Haha, sure, knock yourself out. Add all fixes to this PR to get tests back to green. :) Thanks!
Annoyingly the tests seem to fail in TravisCI. Unfortunetly, I have minimal experience with TravisCI and setting it up so I'll probably have to bow out at this point.
No worries ... it has to do with the Postgres database setup ... I'll try to fix it with the update.
While working on the non cacheable test I submitted earlier I noticed that a couple of the tests used
'
instead of"
which would stop the variable parsing.