search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.25k stars 212 forks source link

Fixed string template syntax in CachedBuilderTest #298

Closed Hornet-Wing closed 4 years ago

Hornet-Wing commented 4 years ago

While working on the non cacheable test I submitted earlier I noticed that a couple of the tests used ' instead of " which would stop the variable parsing.

mikebronner commented 4 years ago

@Hornet-Wing Thanks for this! I will try to get to it this weekend. :)

Hornet-Wing commented 4 years ago

No problem, there are a couple of other things I noticed. For example, the PaginationTest specifically looks for 6.0 version but with Laravel following semver it wont be possible to follow it like this (we're already at 6.2).

mikebronner commented 4 years ago

@Hornet-Wing yea, I'll get all those things addressed when I get all tests to green.

Hornet-Wing commented 4 years ago

Again, I'm happy to lend a hand if you'd like! Now that I've got the tests running locally, it won't be too much work.

mikebronner commented 4 years ago

@Hornet-Wing Haha, sure, knock yourself out. Add all fixes to this PR to get tests back to green. :) Thanks!

Hornet-Wing commented 4 years ago

Annoyingly the tests seem to fail in TravisCI. Unfortunetly, I have minimal experience with TravisCI and setting it up so I'll probably have to bow out at this point.

mikebronner commented 4 years ago

No worries ... it has to do with the Postgres database setup ... I'll try to fix it with the update.