search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.24k stars 213 forks source link

Fix broken limit test #330

Closed dmason30 closed 4 years ago

dmason30 commented 4 years ago

Is there a good reason for phpunit config to have stopOnFailure=true ? I have always used it as false since it hides other failing tests especially on CI tools?

mikebronner commented 4 years ago

True, but it makes it much easier for local development. If there is an error in the CI, I generally never look at all the errors, but only the fact that it errored. Then I go to my local machine and run the tests, failing at the first error. Often subsequent errors are artifacts of the first one.