Closed dmason30 closed 4 years ago
Not sure if this was necessary, since the builds are passing? Probably doesn't hurt, though.
@mikebronner Its still not working in master see nova is not installing see line 445 on the below travis log: https://travis-ci.org/github/GeneaLabs/laravel-model-caching/jobs/679088787#L445
In master it should be running 198 tests it is still skipping the nova tests (7 nova tests/ 191 other).
Actually, it is downloading. Look at line 448. There must be another reason why Nova tests aren't running?
@mikebronner Just noticed you moved the nova tests and you added to phpunit.xml
https://github.com/GeneaLabs/laravel-model-caching/blob/master/phpunit.xml#L21
But you didnt add the new test directory to the phpunit.xml.dist
which is what travis is using.
Alos at the same time you can remove this: https://github.com/GeneaLabs/laravel-model-caching/blob/master/phpunit.xml.dist#L15
Doh! Forgot about php-unit.xml.dist -- thanks for finding that!
It appears when you merged in the master build passed but it failed to install nova and therefore didn't run those tests hopefully this fixes it although you might just want to do some trial and error on master instead of merging this PR.