search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.24k stars 213 forks source link

Fix nova install #340

Closed dmason30 closed 4 years ago

dmason30 commented 4 years ago

It appears when you merged in the master build passed but it failed to install nova and therefore didn't run those tests hopefully this fixes it although you might just want to do some trial and error on master instead of merging this PR.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 92.308% when pulling 4f2bc0148c4ee8e631caa8ab391d32a44ec68313 on dmason30:fix-non-pr-nova into d5c930af6790447841d298891f3dd7799b7080c1 on GeneaLabs:master.

mikebronner commented 4 years ago

Not sure if this was necessary, since the builds are passing? Probably doesn't hurt, though.

dmason30 commented 4 years ago

@mikebronner Its still not working in master see nova is not installing see line 445 on the below travis log: https://travis-ci.org/github/GeneaLabs/laravel-model-caching/jobs/679088787#L445

In master it should be running 198 tests it is still skipping the nova tests (7 nova tests/ 191 other).

mikebronner commented 4 years ago

Actually, it is downloading. Look at line 448. There must be another reason why Nova tests aren't running?

dmason30 commented 4 years ago

@mikebronner Just noticed you moved the nova tests and you added to phpunit.xml https://github.com/GeneaLabs/laravel-model-caching/blob/master/phpunit.xml#L21

But you didnt add the new test directory to the phpunit.xml.dist which is what travis is using.

Alos at the same time you can remove this: https://github.com/GeneaLabs/laravel-model-caching/blob/master/phpunit.xml.dist#L15

mikebronner commented 4 years ago

Doh! Forgot about php-unit.xml.dist -- thanks for finding that!