search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.24k stars 213 forks source link

PHP 7.2 #347

Closed denisdulici closed 4 years ago

denisdulici commented 4 years ago

First of all, thanks for the tremendous work done on this package.

Laravel 7 requires PHP 7.2 version. Why don't you respect it?

Why don't you make a nova-model-caching package wrapping this one instead of removing features general Laravel users?

denisdulici commented 4 years ago

Furthermore, such a critical change is done in a patch version and suddenly our software failed!

mikebronner commented 4 years ago

Hi @denisdulici, thanks for writing in. You are absolutely right about the PHP version. I went ahead and adjusted that. Please try release 0.8.5 and let me know how that works for you.

I'm not sure I understand you second point about Nova? No functionality is being removed to accommodate Nova. We are adding additional tests to make sure it works with Nova.

mikebronner commented 4 years ago

Furthermore, such a critical change is done in a patch version and suddenly our software failed!

Can you elaborate on which patch broke what?

denisdulici commented 4 years ago

In fact, it doesn't break any feature, yet. However, it doesn't pass tests.

As for Nova, it seems you changed it for the sake of Nova. That's why I thought that if it's required for Nova, why not create a new package?

denisdulici commented 4 years ago

Woohoo, just saw the fix release. Thanks for the prompt response 😉

mikebronner commented 4 years ago

I'm also updating our own tests to include different PHP versions now in actions.

mikebronner commented 4 years ago

Going to close this for now, assuming everything is good on your end?

denisdulici commented 4 years ago

Yep, it worked fine, thanks again.