search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.24k stars 213 forks source link

PHP 7.2 action not actually working #348

Closed dmason30 closed 4 years ago

dmason30 commented 4 years ago

https://github.com/GeneaLabs/laravel-model-caching/blob/7e7f527b0e845ab410c78324de5af7e31f61f993/.github/workflows/laravel.yml#L17

The setup php action does not support characters in the version provided from the matrix.

https://github.com/GeneaLabs/laravel-model-caching/blob/7e7f527b0e845ab410c78324de5af7e31f61f993/.github/workflows/laravel.yml#L33

This is resulting in this ⚠️ silent ⚠️ error:

image https://github.com/GeneaLabs/laravel-model-caching/runs/639471767?check_suite_focus=true#step:6:9

So this is actually running tests on 7.4 (i think).

This should be changed to 

php: [7.2, 7.3, 7.4]

Note: There is no way to force it to install a particular patch version of PHP at this time and you shouldn't need to?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mikebronner commented 4 years ago

Closing this, as I have come to a decision to no longer support PHP 7.2 going forward.