search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.24k stars 214 forks source link

Fix PHP 7.2 action #350

Closed dmason30 closed 4 years ago

dmason30 commented 4 years ago

Fixes #348

I have had to remove a dev dependency that was causing composer to fail install.

https://github.com/sebastianbergmann/phpcpd

I tried changing version to ^4.0|^5.0 but composer still failed.

If you are using this somewhere externally you will have to find a workaround for php 7.2.

dmason30 commented 4 years ago

@mikebronner Should I close this? It does fix the PHP 7.2 action but I understand you may be using the removed package externally somewhere.

mikebronner commented 4 years ago

@dmason30 nono :) sorry, this just hasn't been a priority. I still intend to address this at some point.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mikebronner commented 4 years ago

I'm opting not to move forward with PHP 7.2 testing due to incompatibility.