Closed saernz closed 4 years ago
@saernz Thanks so much for this, this is awesome! I will take a look first thing in the morning.
@mikebronner Thanks for the merge man! That's weird there was that compatibility issue that the tests didn't pick up, thanks for fixing it all up.
I think it was because the tests weren't triggering the case where the scopes weren't applied yet. Will experiment with that a bit and see if we can't get a test to do that.
This should fix #289 by overriding the builders implementation of
applyScopes()
to make it check if scopes have been applied already before attempting to apply them again.