issue with "Cachable:applyScopes() : self" not compatible with "Eloquent\Builder::applyScopes()"

mikebronner / laravel-model-caching

Eloquent model-caching made easy.

MIT License

2.24k stars 214 forks source link

issue with "Cachable:applyScopes() : self" not compatible with "Eloquent\Builder::applyScopes()" #359

Closed olivM closed 4 years ago

olivM commented 4 years ago

Declaration of GeneaLabs\LaravelModelCaching\Traits\Cachable::applyScopes(): GeneaLabs\LaravelModelCaching\Traits\Cachable must be compatible with App\Models\Teaching::applyScopes(): App\Models\Teaching

seems the newly added applyScopes with return type hinting is causing a problem

mikebronner commented 4 years ago

Will fix ASAP ... wonder why that didn't show when testing. Might need to add another test.

mikebronner commented 4 years ago

@olivM can you try release 0.8.8? Should be fixed now.

olivM commented 4 years ago

same error with 0.8.8 Caching::applyScopes() hasn't changed : https://github.com/GeneaLabs/laravel-model-caching/blob/master/src/Traits/Caching.php#L35

mikebronner commented 4 years ago

Lordie! I forgot to push my commits. Try 0.8.9. Thanks for letting me know!