PivotEventTrait method not applied

[Tjab]

Describe the bug My PHPStorm shows an error:

Environment

• PHP: [e.g. 7.3.0]
• OS: Homestead (newest)
• Laravel: 7.16.1
• Model Caching: 0.8.6

Additional context Shouldn't be my problem to fix right? As soon as I place (in my class that uses the Cachable trait):

protected function newBelongsToMany(Builder $query, Model $parent, $table, $foreignPivotKey, $relatedPivotKey, $parentKey, $relatedKey, $relationName = null)
{
}

It's fixed, but I believe it should be fixed in the trait itself?

[mikebronner]

@Tjab could you provide your model code for review? Thanks!

[Tjab]

@mikebronner sure, but now you make me doubt as to if it's something that I'm doing wrong! Haha :)

As soon as I create a class and use the trait, the error shows.

<?php

namespace app\Models;

use GeneaLabs\LaravelModelCaching\Traits\Cachable;
use Illuminate\Database\Eloquent\Model;

class ExampleClass extends Model
{
    use Cachable;
}

[mikebronner]

@Tjab Thanks for the update! :) I will take a look, but am wondering if it isn't a bug in PHPStorm, as I haven't had this error show up when running code.

[mikebronner]

Revisiting the code, I think its a PHPStorm bug. There are only two places this function exists in regard:

• laravel-pivot-events/src/traits/ExtendRelationsTrait.php
• Laravel-model-caching/src/Traits/ModelCaching.php

However, in Cachable we are overriding the method from laravel-pivot-events to use the one from ModelCaching. I believe it is this that PHPStorm has issue with interpreting correctly:

    use PivotEventTrait {
        ModelCaching::newBelongsToMany insteadof PivotEventTrait;
    }

All tests pass without any errors when running the code, so it's likely something other than the code in this case. I'll close for now. Thanks for bringing this up, I hadn't seen this before, as I don't use PHPStorm anymore.

[Tjab]

Thanks for the work/help! I've reported it at PHPStorm :) Hopefully they can fix it easily, it's very annoying! Thanks again!

Edit: It was already reported (I made a double).

https://youtrack.jetbrains.com/issue/WI-54284

Thanks again for your reply! Lets hope they update this fast ;)

[mikebronner]

@Tjab Good luck! Let me know what they say. :) Thanks :)