search

mikebronner / laravel-model-caching

Eloquent model-caching made easy.
MIT License
2.22k stars 212 forks source link

Laravel v10.3.0 breaks LaravelModelCaching #445

Closed Bjornftw closed 1 year ago

Bjornftw commented 1 year ago

Describe the bug Laravel v10.3.0 is using an updated version of paginate().

Declaration of GeneaLabs\LaravelModelCaching\Traits\Buildable::paginate($perPage = null, $columns = [...], $pageName = 'page', $page = null) must be compatible with Illuminate\Database\Eloquent\Builder::paginate($perPage = null, $columns = [...], $pageName = 'page', $page = null, $total = null)

Environment

faytekin commented 1 year ago

https://github.com/laravel/framework/pull/46336 happens because of the change made here.

Bjornftw commented 1 year ago

Fixed in 0.13.2 (https://github.com/GeneaLabs/laravel-model-caching/commit/1fe37744efa9d5ed3d8c245c68271022b0e452ab) https://github.com/GeneaLabs/laravel-model-caching/releases/tag/0.13.2