Fix failing tests - Githubissues

mikebronner / laravel-model-caching

Eloquent model-caching made easy.

MIT License

2.22k stars 212 forks source link

Fix failing tests #463

Open mikebronner opened 3 months ago

mikebronner commented 3 months ago

There are a few tests that recently started failing. These need to be investigated and fixed.
Also, the test workflow needs to be updated.

I don't believe that the failing tests are representative of logic failure in the package, rather it is probably due to intentional changes made to the logic, to which the tests no longer comply.

Happy to accept any PRs that address the failing tests, otherwise will look into it over the next few days.

daika7ana commented 3 weeks ago

Fixed one of the failing tests. Sadly when I ran my tests locally I could not test for Nova as I don't own it. Please take a loot at PR #469