search

mikebronner / laravel-sign-in-with-apple

Provide "Sign In With Apple" functionality to your Laravel app.
MIT License
447 stars 67 forks source link

Shorten config keys #7

Open netpok opened 4 years ago

netpok commented 4 years ago

All factory included socialite packages are using relatively short keys like GOOGLE_CLIENT_ID, I think it would make reading the config and env easier if this package would use APPLE_CLIENT_ID. The unnecessary (in my opinion) SIGN_IN_WITH_ part just adds visual clutters.

eliasjtg commented 4 years ago

I think just like you

mikebronner commented 4 years ago

@netpok Thanks for the suggestions. I'll consider this in the future.