search

mikebronner / nova-map-marker-field

Provides an visual interface for editing latitude and longitude coordinates.
MIT License
131 stars 36 forks source link

option to show other markers #30

Open Dontorpedo opened 4 years ago

Dontorpedo commented 4 years ago

Hi, a option to show other markers / or all on the detailpage would be nice.. or maybe only nearby..

thanks Denis

mikebronner commented 4 years ago

Hi @Dontorpedo thanks for submitting that idea. However, for now I think I will leave that feature out, because it doesn't really match with the intended purpose of this package. Could you expand on why this feature is important to your use-case?

Dontorpedo commented 4 years ago

Hi, yes!

it would be very helpfull for winter service tour planning, and services that are charged depending how many customers are nearby

mikebronner commented 4 years ago

@Dontorpedo Thanks for following up. For that to be programmatically useful though, I would think you would need to have more information returned than just the coordinates of the marker. For example, you would need the coordinates of the nearby markers, perhaps with distance and direction from the original marker, to be able to use it in any significant way.

Further, how would you determine which markers to show? Would they need to be based on specific criteria, distance, attributes, etc.? All these things are beyond what this Nova field is designed for.

This field is intended solely for determining lat/long coordinates of a given point on the map.

For more complex things, it is probably better to create your own custom field with the specific functionality you need, or perhaps even not do it in Nova, but have it be first-citizen functionality of your app.

I'm only guessing, of course, based on your short description -- it's difficult for me to envision exactly what your intentions are.

mikebronner commented 4 years ago

I can see what you mean by showing other markers nearby on the detail screen to give context, though.

If we limited it to nearby markers, we would have to have GIS functionality in the database to calculate distance in the where clauses. If we loaded all markers, it could quickly crash the page.

I'm going to put this on hold for now, but keep it here in case I can think of a good way to implement it. I'll be happy to consider a PR if you want to submit one and it is performant :).