search

mikebronner / panic-nova-phpcs.novaextension

https://extensions.panic.com/extensions/genealabs/genealabs.phpcs/
MIT License
2 stars 1 forks source link

Add config option for executable path #2

Closed davisben closed 3 years ago

davisben commented 3 years ago

Resolves #1

mikebronner commented 3 years ago

Hi @davisben, thanks so much for submitting this PR! I actually had this in place, but temporarily removed it as I was researching some issues. I'll go ahead and add it back in. Closing this PR, as I already have the code.

mikebronner commented 3 years ago

@davisben just FYI: I have pushed a few new version since yesterday, one of which includes this feature. Let me know how it works for you. :) Thanks again for submitting the issue and PR!

davisben commented 3 years ago

Looks good here. Thanks for your work on this!

mikebronner commented 3 years ago

That's awesome! Thanks for the feedback. Out of curiosity, what is your use-case for needing to customize the executable? (The only reason I currently need to customize it is to load a custom CodeSniffer.conf file.) I'm eager to learn of other use-cases that I can keep in mind while improving functionality.

Thanks! ~Mike

davisben commented 3 years ago

I have some standards installed by composer that weren't being found by the included executable, so by setting the path to the phpcs executable in vendor/bin, those standards were found.

mikebronner commented 3 years ago

Ah, yes! I'm doing the same. Was thinking of letting the user provide a path to their CodeSniffer.conf standards file and let it load that one, regardless of where PHPCS is installed. Still working on that. :)