Feature Request: Mark current time in plot

hausler89 commented 4 years ago

A vertical bar indicating the current (browser local) time would be useful. Thanks for the great tool :)

abrad45 commented 4 years ago

I started looking into this and... It's nontrivial to tell what the request is here, given the granularity of the data in the chart itself. The chart does not show specific times, but rather time windows.

Vague Chart Times

Sunday is technically only valid for the hours Daisy Mae is on your island, 5-12am. The hours from Sunday at noon to Monday morning at 8am when Nook's Cranny is open and next buying turnips is unaccounted for in the graph
Monday AM (and each other day's AM) encompasses the four hour block from 8am-12pm.
Monday PM (and each other day's PM) encompasses the 10 hour block from 12pm-10pm.

Due to this, knowing what to show is tricky. We could highlight, in some way, the label which encompasses the current time, but then what would we show during times like:

Sunday from noon to midnight?
Each day from midnight to 7:59am?
Each day from 10:01pm - midnight?

Global vs. Local time

Additionally, since the game doesn't use a global clock, but rather users' local time, telling them which of the games' time windows they are is not particularly useful, given that the site already informs users of the time windows:

AM - 8:00 am to 11:59 am PM - 12:00 pm to 10:00 pm

We'd basically be telling them the time, which I suppose could be useful in some contexts, but with such wide time windows, I don't know what we're gaining there.

Conclusion

I'm not sure of a solution that is useful, complete and clear. I'm not a contributor or owner of this project, so I won't speak to anyone else, but wanted to drop some notes in here, rather than looking into this without solving anything. Hope it helps someone.

Resources

Drawing a vertical line in ChartJS: https://stackoverflow.com/questions/30256695/chart-js-drawing-an-arbitrary-vertical-line

theRTC204 commented 4 years ago

Thank you @abrad45 for the detailed analysis. Generally this was my feeling as well. In addition to it being non-trivial to identify the correct time window, it's also not particularly difficult to use the graph's tooltip to understand what window of time the points are for.

The graph only has 13 points, so finding the touch/hover point is not very difficult, even on smaller screens.

I'm still open to the idea, if someone has a novel solution to propose, but for the moment it's a low priority for myself to address.

mikebryant / ac-nh-turnip-prices