search

mikebryant / ac-nh-turnip-prices

Price calculator/predictor for Turnip prices
https://turnipprophet.io
Apache License 2.0
1.45k stars 244 forks source link

Alternate color scheme for colorblind users #254

Open boosterbeetle opened 4 years ago

boosterbeetle commented 4 years ago

Just noticed the new colors to represent good/bad prices but as someone with red/green colorblindness it's pretty difficult to distinguish between the shades of green. Also checked out the dark mode equivalent and the shades of purple? are also difficult to tell. Not a deal breaker by any means but just leaving some feedback in case you want to add support for other schemes in the future. All in all, great work.

theRTC204 commented 4 years ago

Great suggestion. There are a handful of things we should do for accessibility.

davidcorry commented 4 years ago

I've made an initial pass at a higher contrast theme, that should (hopefully) work across the different forms of colorblindness. I don't have any colorblindness, though, so I was relying on an app to simulate it for me. Any feedback from folks who this would benefit would be great! (@boosterbeetle)

I haven't made a dark mode, but depending on interest I can see about how to handle the logic for that.

image image
boosterbeetle commented 4 years ago

@davidcorry Screenshot looks good! Easier to tell between different sets of values now.

davidcorry commented 4 years ago

Rad! If anything needs adjusting, let me know. I’ll likely come up with a dark mode version in the next day or two and hopefully we can get it in soon.

boosterbeetle commented 4 years ago

Yeah, not sure if others want to pitch in but for me, I had a hard time distinguishing between the best and second best values in the previous color scheme (shades of green used were very similar). It's solved here though as one of the blue is much darker than the other one. Don't know if that still causes problems with other users though.