mikebryant / ac-nh-turnip-prices

Price calculator/predictor for Turnip prices
https://turnipprophet.io
Apache License 2.0
1.45k stars 244 forks source link

Price prediction bug #306

Open yurawizard opened 4 years ago

yurawizard commented 4 years ago

Screenshot_20200429-103338 The table isn't reading any options for me. I have uninstalled, and reinstalled. I have also cleared my data, and put it back in. It worked fine last week, but for some reason it is now doing nothing.

theRTC204 commented 4 years ago

Hey there, this occurs when the application cannot find a prediction for the values you've entered.

Can you please provide all those values (preferably in a permalink copied from the app) so we can investigate?

Eond commented 4 years ago

I think this is related to #250

kcmparker commented 4 years ago

I caught the bug! :( lol

https://turnipprophet.io?prices=96.82.113.142.144.146.......&pattern=1

kcmparker commented 4 years ago

I caught the bug! :( lol

https://turnipprophet.io?prices=96.82.113.142.144.146.......&pattern=1

Nevermind... missed the "bought on my own island" question - first time buying on my own island should be yes! fixed itself.

gyozapop commented 4 years ago

I am also experiencing this issue. Below is permalink to values:

https://turnipprophet.io/?prices=92.102.94.77.64.69.64......&pattern=3

yurawizard commented 4 years ago

https://turnipprophet.io?prices=103.133.90.56.138.123.......&pattern=3

There's my link.

On Wed, Apr 29, 2020, 10:43 AM Ryan Carbotte notifications@github.com wrote:

Hey there, this occurs when the application cannot find a prediction for the values you've entered.

Can you please provide all those values (preferably in a permalink copied from the app) so we can investigate?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mikebryant/ac-nh-turnip-prices/issues/306#issuecomment-621257251, or unsubscribe https://github.com/notifications/unsubscribe-auth/APMNMHNN42YQUM25FGPVYTLRPA4K3ANCNFSM4MTY75DQ .

theRTC204 commented 4 years ago

I am also experiencing this issue. Below is permalink to values:

https://turnipprophet.io/?prices=92.102.94.77.64.69.64......&pattern=3

@gyozapop this presents as an issue with the numbers entered into the tool. If we follow the phases of a Fluctuating pattern, and we assume that your Monday & Tuesday numbers are correct, and we assume that Wednesday AM was in fact an increase over Tuesday PM, then a value of 69 is not possible there.

Based on the pattern, that would mean your rate for Wednesday AM would have been between 0.9 - 1.4, and even at the lowest value you still end up with 92 * 0.9 = 82.8.

garethrhughes commented 4 years ago

I'm getting the same issue.

https://turnipprophet.io?prices=109.86.79.135.121.113.128.86.63....

Perhaps they changed the logic in a patch?

helena-charles commented 4 years ago

Same problem! https://turnipprophet.io?prices=90.83.113.72.89.172.181.160.....

gyozapop commented 4 years ago

@theRTC204 ok. I’ll include screenshots of each pricing next time to backup my numbers from turnip prophet, if the problem persists next week.

theRTC204 commented 4 years ago

@theRTC204 ok. I’ll include screenshots of each pricing next time to backup my numbers from turnip prophet, if the problem persists next week.

@gyozapop thank you, that would be helpful. The key things we'd want to validate for certain are:

  1. Every value entered was from the same island (buy price & sell prices)
  2. Absolutely no time traveling of any kind was done
gyozapop commented 4 years ago

@theRTC204 I will include that information as well.

theRTC204 commented 4 years ago

Perhaps they changed the logic in a patch?

@garethrhughes the data miner, Ninji, responsible for extracting the game code that this calculator was based upon has confirmed that the Turnip calculation in game has not been changed in any patch. What has been changed is the behavior around when your Turnip prices are thrown away and regenerated for the week.

For example, prior to Patch 1.2, a player could time travel backwards as long as they never crossed over the boundary of a price period. Let's say you were in the Tuesday PM period and you had a great sell price - as long as by 10PM you time traveled back to 12:01PM, you could retain that high sell price forever. Other people could come to your island to sell their Turnips, or you could go to someone elses island to buy them and return to your own to sell.

However, as of Patch 1.2, that is no longer possible. In the current game, time traveling backwards for any amount of time will cause your existing Turnip prices to be thrown out and new ones to be regenerated.

Zombiewendy commented 4 years ago

I am having the same issue. Here is my permalink: https://turnipprophet.io?prices=97.79.76.71.66.130.125.111.156....&pattern=0

Edit: No time travel was done