search

mikebryant / ac-nh-turnip-prices

Price calculator/predictor for Turnip prices
https://turnipprophet.io
Apache License 2.0
1.45k stars 245 forks source link

Infinity options for turnip sales in the future #347

Open hhelmbre opened 4 years ago

hhelmbre commented 4 years ago

Things to check

Describe the bug The entire plot is green with my past three days of turnip prices plotted. The options are - infinity to infinity for all future prices.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Permalink to your prices https://turnipprophet.io?prices=94.84.72.74.71.67.63......&pattern=1

Expected behavior When I typed in a new price, it used to provide a prediction plot. Now it just says all the options are available.

Screenshots

Screen Shot 2020-05-06 at 4 43 41 PM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

FlashPros commented 4 years ago

it seems to not like th e Tuesady pm price when removing that price and leaving all the rest the graph goes back to working my thoughts on that are when removing the Tues pm price it shows that the guaranteed min should be 85 so putting the much lower 71 is whatssz breaking it

i dont know if thats really the case just going based off of what i seen https://turnipprophet.io/?prices=94.84.72.74..67.63......&pattern=1

cr45hmurphy commented 4 years ago

I am currently getting the same "infinite" issue.

Current settings:

First time buyer: No Last week's pattern: Large Spike Sunday's prices: 107 Monday AM: 79 Monday PM: 53

If I enter in anything above 79 for Monday's PM, the graph works. However, anything 62 or below causes the graph to show "infinity".

Permalink: https://turnipprophet.io?prices=107.79.53..........

meeech commented 4 years ago

Same. First time buyer: Yes Last week's Pattern: I don't know perma: https://turnipprophet.io?prices=100.68.63.178.........

raul-perez-m commented 4 years ago

Same. First time buyer: Yes Last week's Pattern: I don't know perma: https://turnipprophet.io?prices=108.150.106.148.105........&first=true

catiemondon commented 4 years ago

Also having a similar issue First time buyer: yes Last weeks pattern: I don't know perma: https://turnipprophet.io?prices=98.124.66.57.105........&first=true

joyeusenoelle commented 4 years ago

Experiencing the same issue. However, I managed to fix it.

First time buyer: No Last week's pattern: Small spike, but the error occurs regardless of what I select Permalink: https://turnipprophet.io?prices=91.89.78.74.70.67.63......&first=true

The issue seems to have been that my value for Tuesday PM (70) was outside the bounds that the script expected (71-74). Changing that value to 71 returned the graph and predictions to normal - and, surprisingly, they remained normal after I changed the Tuesday PM value back to 70.

joyeusenoelle commented 4 years ago

Update: my graph is broken again.

I notice that the link above gives "first time" as true, which is what appears to have fixed the graph. Setting it properly to false gives the infinite result again when Tuesday's correct price is entered. Leaving Tuesday PM's price blank and entering the correct price for Thursday PM also causes an infinite graph.

This happens whenever I enter a value that doesn't conform to what the algorithm has predicted, and my prices suggest that the algorithms may be flawed or incomplete.

Link without Tuesday PM or Thursday PM prices: https://turnipprophet.io?prices=91.89.78.74..67.63......

Link with Tuesday PM's correct price: https://turnipprophet.io?prices=91.89.78.74.70.67.63......

Link without Tuesday PM but with Thursday PM's correct price: https://turnipprophet.io?prices=91.89.78.74..67.63..56....

Setting the "first time" option to true doesn't help with Thursday PM's price; the site offers no algorithm under any circumstances where the Nooks should be offering 56 bells for turnips on Thursday afternoon, given the previous prices.