search

mikebuss / MTBBarcodeScanner

A lightweight, easy-to-use barcode scanning library for iOS 8+
MIT License
1.09k stars 196 forks source link

UIView preview has issues during orientation changes #158

Open jpshelley opened 4 years ago

jpshelley commented 4 years ago

When using the pod in my own app and the example app on an iPad, whenever I rotate the screen the view itself no longer retains its original constraints. Most of the time it appears to take on padding on the side. I'll upload an image once I am able to later

mikebuss commented 4 years ago

@jpshelley can you try comparing your constraints to those in the sample application included in the Project folder of this repo? If you are able to reproduce this issue in the sample app, that would be helpful for debugging this.

mikebuss commented 4 years ago

I am going to close this issue for now. @jpshelley if you can reproduce this issue in the included demo projects, please feel free to update this ticket. If you are not able to reproduce the issues in the demo project, it's likely an issue with your constraints.

If there's something specific you're trying to achieve, you may want to update the demo projects to see what step introduces the issue.

jpshelley commented 4 years ago

Yes I can reproduce it in the example app even. I'll upload an image/video sometime this week.

sashahilton00 commented 4 years ago

@mikebuss this issue is indeed present. I have just seen the behaviour on the sample app. You can see the problem in the video uploaded here: Streamable essentially, the library ceases to recognize codes on an orientation change, requiring a restart of the scanner before it starts recognising again.

mikebuss commented 4 years ago

Thanks @sashahilton00. I'll reopen this and take a look. It may be that you need to supply a new scanRect when the orientation changes, but I'll update the ticket with what I find.

mikebuss commented 4 years ago

Sorry for the delay in responding to this.

I am not longer actively maintaining this library, but if anyone reading this has a solution and wants to submit a pull request I will merge it in. Apologies for the inconvenience.