mikecao / sparrow

A simple database toolkit for PHP
MIT License
289 stars 68 forks source link

Expire not used in execute #32

Open raxan opened 7 years ago

raxan commented 7 years ago

In execute() method the param $expire seem not used, here:

https://github.com/mikecao/sparrow/blob/master/sparrow.php#L756-L762

seem that fetch() check inside cached file expiration, here for example:

https://github.com/mikecao/sparrow/blob/master/sparrow.php#L1297

is this an issue or missing check of expiration? seem only file cache check it.

thanks

mikecao commented 7 years ago

You're right, it looks like the execute method doesn't use it. However everything should still work. Only the file cache checks the expire value, because all the other caches, like memcached handle expiration natively. See the store method.