Alter odd emphasis, fix some typos, add links

mikechau / react-primer-draft

A primer for building web applications with React.

Other

3.65k stars 104 forks source link

Alter odd emphasis, fix some typos, add links #6

Closed xmo-odoo closed 9 years ago

xmo-odoo commented 9 years ago

I have serious trouble reading the existing emphasis which uses code spans (and there's a bit too much of it), this branch either removes emphasis or replaces the code spans with regular emphasis where the content is not code.

Also:

fixes a few typos
rephases a few things
add links where that seemed to make sense
replaces Component#getDOMNode() calls by React.findDOMNode(Component) (that might be a bit of an issue as, according to #4, this is a React 0.12 guide and I assumed 0.13)

mikechau commented 9 years ago

Wow, very nice! Thank you. :+1:

Do you think you could keep Component#getDOMNode(), but include React.findDOMNode, but comment it out and say it is for 0.13+?

xmo-odoo commented 9 years ago

Sure, done.

mikechau commented 9 years ago

:bow:

mikechau commented 9 years ago

I'm reading over your changes again @xmo-odoo and I'm really impressed. Thank so much, would you be interested in being a reviewer?