search

mikeckennedy / python-jumpstart-course-demos

Contains all the "handout" materials for my Python Jumpstart by Building 10 Apps course. This includes try it yourself and finished versions of the 10 apps.
https://talkpython.fm/course
MIT License
746 stars 537 forks source link

Want to add more instructions for creating Python virtualenv in Windows. #44

Closed xzackaly closed 5 years ago

xzackaly commented 5 years ago

Hi, Mike.

I hit a speed bump trying to set up python virtual environment on Windows, but figured it out through G-search (Google).

I am asking permission to do a PR to update the document “venv_on_windows.md”.

  1. The “Scripts\activate” in the tutorial DOES work in Windows, without needing “.bat”. The key to getting the Windows shell to work as desired is to do a one-time change to some default shell script settings. Until I made the script settings change, I was unsuccessful at getting activate or activate.bat to work.

  2. The “where” command is “where.exe” (where.exe virtualenv).

  3. And finally, I would like to add the shell command format for creating a virtual environment for earlier versions of Python, pre-Python3.3.

Thanks for your consideration.

@xzackaly

1oglop1 commented 5 years ago

Hi @xzackaly Do not ask persmission to create PR, but rather create it with suggested changes :) Checkout the link below for detailed information. https://help.github.com/en/articles/creating-a-pull-request

mikeckennedy commented 5 years ago

Hi guys. Definitely go ahead and do the PR. @1oglop1 I agree, no need to ask permission in general. Sometimes I'm a little touching about improvements because I value having the code match the video recording more than having perfect code so don't want to waste people's time. That said, a markdown doc to help folks on Windows is definitely welcomed.

xzackaly commented 5 years ago

Thanks, Mike. : )

mikeckennedy commented 5 years ago

Thank you!