search

mikecole / chocolatey-packages

A template to use when setting up to create packages both manual and automatic
Apache License 2.0
7 stars 20 forks source link

zoom - Fix inconsistent package name #162

Closed brogers5 closed 1 year ago

brogers5 commented 1 year ago

zoom's install script has been passing an incorrect package name (zoom-client) to Install-ChocolateyPackage since v5.0.23168.0427, likely due to the script being derived from zoom-client. The package name is printed to the console during install, so this could potentially be misleading.

Changing packageName accordingly to reference the ChocolateyPackageName environment variable instead, to both correct the discrepancy and make this more resilient to any future code reuse or package name changes.

mikecole commented 1 year ago

I was unaware of that environment variable. Thanks!

mikecole commented 1 year ago

Since the package automatically updates frequently I just may let this sit and go out on the next auto-update since it's not a pressing matter. Thanks again.

brogers5 commented 1 year ago

Not a problem, thanks for merging!