Add support for working hours. Fixes #3

mikeconley / myqonly

A tool for Mozillians who want to know how many reviews are in their queue in their browser.

Mozilla Public License 2.0

11 stars 12 forks source link

Add support for working hours. Fixes #3 #13

Closed jaredhirsch closed 5 years ago

jaredhirsch commented 5 years ago

Add day and time pickers to the options page
Clear the review badge if the update interval runs outside the working hours

Here's the options page with the UI as implemented:

jaredhirsch commented 5 years ago

Thanks for the quick review. Should get these updates in tomorrow at lunch, I reckon

Callek commented 5 years ago

Drive-By:

Day of week information is very locale specific and can vary, e.g. first day isn't always Sunday. -- We have docs for this https://firefox-source-docs.mozilla.org/intl/dataintl.html?highlight=mozintl#mozintl-getcalendarinfo-locale

I'm not sure if it's available to web extensions though (nor am I sure if we care about it for the purposes of this extension) so I'm just raising it here. :Gandalf would know if it is available to web extensions.

jaredhirsch commented 5 years ago

@mikeconley Looks like this might not happen as soon as I'd hoped. Are you still up for doing the final tweaks?

mikeconley commented 5 years ago

Sure thing - I can take this over the line. Thanks for the start!

mikeconley commented 5 years ago

Merged without addressing the original feedback. I'll apply the feedback later.