search

mikecsh / dokku-app-url

Makes app URL available as environment variable
BSD 2-Clause "Simplified" License
2 stars 2 forks source link

I'm not sure how, but app-url breaks ps:rebuild #2

Open jimeh opened 9 years ago

jimeh commented 9 years ago

Using Dokku v0.3.22 and this plugin, rebuilding apps seem to break.

I'm using my kotaku-uk-rss project in these examples.

First with no 3rd-party plugins installed:

$ dokku ps:rebuild kotaku-uk-rss
-----> Cleaning up...
-----> Building kotaku-uk-rss from buildstep...
-----> Adding BUILD_ENV to build environment...
-----> Go app detected
-----> Using go1.3
-----> Running: godep go install -tags heroku ./...
-----> Discovering process types
       Procfile declares types -> web
-----> Copying any files from app's .dokku-config/* to /home/dokku/kotaku-uk-rss... 180bc5c0b4958b1f0ffd4c1eff25f4d73d1da9265a35f3bfe510e4d7b9882992
-----> Releasing kotaku-uk-rss...
-----> Deploying kotaku-uk-rss...
-----> Running pre-flight checks
       For more efficient zero downtime deployments, create a file CHECKS.
       See http://progrium.viewdocs.io/dokku/checks-examples.md for examples
       CHECKS file not found in container: Running simple container check...
-----> Waiting for 10 seconds ...
-----> Default container check successful!
=====> kotaku-uk-rss container output:
       fetching and parsing articles from: http://www.kotaku.co.uk/
       fetching and parsing articles from: http://www.kotaku.co.uk/page/2/
       fetching and parsing articles from: http://www.kotaku.co.uk/page/3/
       building feed cache... done
       taking a nap for 60 seconds ^_^
=====> end kotaku-uk-rss container output
-----> Running post-deploy
-----> Configuring kotaku-uk-rss.dokku.me...
-----> Creating http nginx.conf
-----> Running nginx-pre-reload
       Reloading nginx
-----> Shutting down old containers in 60 seconds
=====> 2196cbc2c108b995e39f61e9e4b8148ddae1e5f19a41b23f2de8fdb7e35022e6
=====> Application deployed:
       http://kotaku-uk-rss.dokku.me

And then with only the app-url plugin installed:

$ dokku ps:rebuild kotaku-uk-rss
-----> Cleaning up...
-----> Building kotaku-uk-rss from buildstep...
-----> Injecting APP_URL
-----> Setting config vars
       APP_URL: http://kotaku-uk-rss.dokku.me
-----> Restarting app kotaku-uk-rss
-----> Releasing kotaku-uk-rss ...
-----> Deploying kotaku-uk-rss ...
-----> Running pre-flight checks
       For more efficient zero downtime deployments, create a file CHECKS.
       See http://progrium.viewdocs.io/dokku/checks-examples.md for examples
       CHECKS file not found in container: Running simple container check...
-----> Waiting for 10 seconds ...
App container failed to start!!
=====> kotaku-uk-rss container output:
=====> end kotaku-uk-rss container output
/var/lib/dokku/plugins/ps/functions: line 5:  5163 Killed                  dokku deploy "$APP"
mikecsh commented 9 years ago

Hi @jimeh,

Sorry that you are having issues with this. Unfortunately I'm not actively maintaining this plugin at the moment due to lack of time. Dokku changed the process for buildsteps back in February and this is likely related to that change. If you are interested in forking/patching the code, this is the only information I have:

pre/post-build will be renamed to pre/post-build-buildstep and pre/post-release to pre/post-release-buildstep

All the best, Mike

jimeh commented 9 years ago

Hey, thanks for the info. I had already tried to quickly rename the hook file, which kind of worked, except the hook ran over and over in an infinite loop. At that point I gave up and focused on getting my apps deploying instead... lol

But I'll try to fix it up at some point when I have some free time :)

bulleric commented 9 years ago

Please, if possible put a big BROOOKEN to the main page. Because i also struggeld some hours with that problem

mikecsh commented 9 years ago

Hi @bulleric, thanks for the suggestion - I've put a big warning notice up. Apologies for your wasted efforts!