mikedeboer / jsDAV

jsDAV allows you to easily add WebDAV support to a NodeJS application. jsDAV is meant to cover the entire standard, and attempts to allow integration using an easy to understand API.
http://www.mikedeboer.nl
MIT License
681 stars 159 forks source link

Space in filename is not recognized #155

Open MeteorStartup opened 7 years ago

MeteorStartup commented 7 years ago

I've got filename something like this, Boot%20Camp%20(Imported).vmwarevm.zip and that is not available to download on the browser.

The Browser shows following XML error document which could not find the path.

http://i.imgur.com/3pDESkg.png

Is there a option or some convenient way to solve this?

mikedeboer commented 7 years ago

In your screenshot it looks like you're putting the %20 in there yourself: http://stackoverflow.com/a/16085190 I don't know how you generated that link, but I'd suggest looking there first...

mblum14 commented 7 years ago

I had the same issue. When hosting a filename with a space in the name (e.g., Boot Camp (Imported).vmwarevm.zip), it is listed as Boot%20Camp%20(Imported).vmwarevm.zip in the browser and clicking on it results in the XML 404 error. If I change the filename to just BootCamp(Imported).vmwarevm.zip everything seems to work.

mikedeboer commented 7 years ago

@mblum14 that sounds like a straightforward issue where jsDAV doesn't escape the path properly. I don't have the time to look at this issue currently, but I'd be happy to mentor someone who wants to fix it.

MeteorStartup commented 7 years ago

so the issue was not solved yet? I got same issue on version 0.3.4 I didn't change any options and I got url something like this, filename%20something.dmg

something I found on the web was explained this issue to 'double urlencoding' issue. if that was right, that should be fixed on next version-