search

mikedeboer / jsDAV

jsDAV allows you to easily add WebDAV support to a NodeJS application. jsDAV is meant to cover the entire standard, and attempts to allow integration using an easy to understand API.
http://www.mikedeboer.nl
MIT License
681 stars 159 forks source link

Postgre #80

Closed dlaxar closed 10 years ago

dlaxar commented 11 years ago

Adding Postgre support for CardDAV

mikedeboer commented 11 years ago

WOW! That looks awesome, even includes tests... <3

I'll check it out as soon as possible, when I have time to feature test it. One nit I noticed in the diff is that the files don't contain a newline at the end... you might want to fix that :smile:

dlaxar commented 11 years ago

Glad you like it. I fixed the newlines :)

pygy commented 11 years ago

FWIW, the name is either PostgreSQL [[post-GRESS-Q-L]] or Postgres [[post-GRESS]]. The former being the the official name.

PostgreSQL is the next installment of Ingres.

You're not the only one committing the error... Even some of the PostgreSQL authors regret the name choice, because of the hard pronounciation and the non-obvious abbreviation.

mikedeboer commented 11 years ago

I vote for the name 'postgres', after reading what @pygy said :smile:

mikedeboer commented 11 years ago

@dlaxar did you have time to look at the comments I made earlier?

dlaxar commented 10 years ago

Sorry it took so long - I should have fixed all the issues. Hope this helps

mikedeboer commented 10 years ago

@dlaxar I do see many formatting nits, but I'll fix those up right after the merge. OK?

Thanks for picking this up again! Much appreciated :)

dlaxar commented 10 years ago

I didn't see any but maybe I'm just overseeing them. Thank you :)

mikedeboer commented 10 years ago

Please see commit 376172e41dbf7815c0176b72b43ff1e58cc48575 for all the fixes.