search

mikedeboer / jsDAV

jsDAV allows you to easily add WebDAV support to a NodeJS application. jsDAV is meant to cover the entire standard, and attempts to allow integration using an easy to understand API.
http://www.mikedeboer.nl
MIT License
681 stars 159 forks source link

Fix bug of PROPFIND #91

Closed johnsonlee closed 10 years ago

johnsonlee commented 10 years ago

when request an empty folder with depth 0, it isn't supposed to be responded with any children.

mikedeboer commented 10 years ago

Alright, this actually seems reasonable to me :) Thanks and apologies for it taking so long for me to respond!

aenario commented 10 years ago

@johnsonlee, with this change, requests such as : 

PROPFIND /public/calendars/me/my-calendar/
DEPTH 1
<?xml version="1.0" encoding="UTF-8"?>
<propfind xmlns="DAV:">
       <prop>
           <CS:getctag xmlns:CS="http://calendarserver.org/ns/"/>
           <getetag/>
      </prop>
</propfind>

do not return the parent (Calendar ~ Collection) element properties. Was this the behaviour you were looking for ? This breaks compatibility with some caldav clients.

mikedeboer commented 10 years ago

@aenario so it's prolly better to back this change out for now?

aenario commented 10 years ago

I think so, full revert is in #99 but i guess the correct way to go is somewhere in between that solve @johnsonlee situation without breaking others

johnsonlee commented 10 years ago

I didn't know much about caldav, I just used PROPFIND to display the file tree, so I found the issue.

Hope to hear from you soon!

Best Regards!

Johnson Lee

On May 28, 2014, at 18:28, Romain Foucault notifications@github.com wrote:

@johnsonlee, with this change, requests such as :

PROPFIND /public/calendars/me/my-calendar/ DEPTH 1 <?xml version="1.0" encoding="UTF-8"?>

do not return the parent (Calendar ~ Collection) element properties. Was this the behaviour you were looking for ? This breaks compatibility with some caldav clients.

— Reply to this email directly or view it on GitHub.