mikedh / trimesh

Python library for loading and using triangular meshes.
https://trimesh.org
MIT License
3.02k stars 583 forks source link

Update transformations.py #2254

Closed apalkk closed 4 months ago

apalkk commented 4 months ago

In the function rotation_matrix the input array direction is being normalised by the the function unit_vector anyways, so there is no need to explicitly require direction to only consist of unit_vectors in the description of rotation_matrix.

mikedh commented 4 months ago

Looks good to me, thanks for the PR!