search

mikedilger / gossip

Gossip is a nostr client
Other
701 stars 79 forks source link

Misplaced url rendering #336

Closed dtonon closed 1 year ago

dtonon commented 1 year ago

note1xg0kgmche45at9djajaf7exgkxsgptdgw6zw2nwtpw8336xm62gqh36k0f

image
bu5hm4nn commented 1 year ago

Is it still an issue after the current merge?

dtonon commented 1 year ago

Yes, I'm experimenting the same problem, both Master and Unstable.

bu5hm4nn commented 1 year ago

Ok this is the same error as #347. It has something to do with the wrapping newline fix I committed to egui a while ago. I'm not sure if I missed an edge case or if an update in egui broke it again. Will investigate.

bu5hm4nn commented 1 year ago

@mikedilger It seems one of my commits didn't make it into your egui/gossip branch. Now I don't know if it is going to solve this, but I did test the fix extensibly for submission to the original egui repo. I don't have the time to resolve the merge conflict with gossip branch so I can't test it locally right now, but I should have time on Thursday.

This is the commit: https://github.com/bu5hm4nn/egui/commit/74e9dd6e1435bba0e3bea217cc9c1c25d3a8eeb1

mikedilger commented 1 year ago

Ok. I cherry-picked it. There was no merge conflict to resolve. I've updated gossip unstable to use the updated egui.

bu5hm4nn commented 1 year ago

Thank you Mike. Didn't seem to be the fix for this issue unfortunately. Oh well, more egui debugging to do...

bu5hm4nn commented 1 year ago

I found a fix that did not seem to have any negative side effects. PR open

mikedilger commented 1 year ago

OK. I didn't look I just merged.

bu5hm4nn commented 1 year ago

@dtonon can you confirm this is fixed in unstable?

dtonon commented 1 year ago

@bu5hm4nn fixed! 👍