search

mikedilger / gossip

Gossip is a nostr client
Other
692 stars 77 forks source link

Inbox - Everything shows one's own notes #752

Closed dtonon closed 4 months ago

dtonon commented 4 months ago

They should be filtered out.

image
mikedilger commented 4 months ago

feed.rs line 439-441 should be filtering this out. I wonder why it isn't:

// exclude if it's my own note
if e.pubkey == my_pubkey {
    return false;
}
mikedilger commented 4 months ago

It was accepting giftwraps and DMs first before hitting those lines. Can you confirm that this note was a DM or giftwrap note @dtonon? I'll put the fix, but if this was a regular note, then this fix won't be enough. Try unstable and let me know.

(I don't see how it could be a DM, but I also can't see how it could have shown up)

bu5hm4nn commented 4 months ago

Hey @mikedilger, I added those lines you quoted to fix this bug, so I think it can be closed.

mikedilger commented 4 months ago

Oh I see. Hah!

dtonon commented 4 months ago

@mikedilger sorry for the delay, it's a regular note.

feed.rs line 439-441 should be filtering this out. I wonder why it isn't:

I actually pushed 68067672 (courtesy of @bu5hm4nn) after opening the issue, but I forgot to update the issue.