search

mikedilger / gossip

Gossip is a nostr client
Other
713 stars 81 forks source link

Request: Thai language #797

Closed vazw closed 4 months ago

vazw commented 4 months ago

image

and I have some problem trying to connect to my local-relay (nostr-relay-tray) ws://localhost:4869 any idea whit this?

bu5hm4nn commented 4 months ago

Hey @vazw . How did you install gossip?

I'm not sure if Thai would be included in lang-cjk support. If you compiled from source you can run cargo run --features=lang-cjk --release to enable it.

Otherwise please post an nevent link to a thai event so we can debug (I don't see any in my feed).

vazw commented 4 months ago

Hey @vazw . How did you install gossip?

I'm not sure if Thai would be included in lang-cjk support. If you compiled from source you can run cargo run --features=lang-cjk --release to enable it.

Otherwise please post an nevent link to a thai event so we can debug (I don't see any in my feed).

cjk does not include tlwg/libthai it's a total diffrent language phonics.

you can try with this event

bu5hm4nn commented 4 months ago

For lang-cjk all we do is add another font. So as I understand all we need is an open source thai font that we can package with gossip.

vazw commented 4 months ago

For lang-cjk all we do is add another font. So as I understand all we need is an open source thai font that we can package with gossip.

Noto also support Thai langauge maybe we can use Noto Sans Thai?

bu5hm4nn commented 4 months ago

@vazw I added the "Noto Sans Thai" font, as we already use Noto for CJK support. Does this screenshot look right or are there characters missing/wrong?

Screenshot 2024-06-24 at 14 39 45
vazw commented 4 months ago

@vazw I added the "Noto Sans Thai" font, as we already use Noto for CJK support. Does this screenshot look right or are there characters missing/wrong?

That's the correct one! Thank you! it's look great🔥

bu5hm4nn commented 4 months ago

@vazw If you build from unstable (git checkout unstable) then you can already use it.

bu5hm4nn commented 4 months ago

@mikedilger Is there still a reason to have lang-cjk as a build switch or should we just compile the languages in as standard? I don't think there's collisions with unicode.

mikedilger commented 4 months ago

Thanks for adding this font @bu5hm4nn

The reason --lang-cjk is a build switch is because the fonts are big and bloat the binary. But maybe that doesn't matter much anymore. Without them the binary is 43 MB (release, stripped) and 63 MB with them (release, stripped). I think the complexity of this build option is probably not worth it anymore.