Review Relays section

[dtonon]

Here are some fixes to clean up and improve (imo) the Relay section:

General interface

• [x] Remove the "Add Relay" button from the sidebar; it is the only case where a button is placed in the sidebar, so it's a inconvenient exception to handle.
• [x] Add the "Add Relay" button on the left of the top search.
• [x] Reduce the width of the search input by 25%.
• [x] Fix the lens position in the search input.
• [x] Move the "Advertise relay list" button inside the top-right dropdown menu.
• [x] Replace the top-right icon for the dropdown with the standard "3 lines" one.
• [ ] Show the mouse pointer when hovering Relay coverage and Advertise relay list

Lists

• [x] Make the whole row clickable, add a hover effect (darker color for dark theme, lighter color for light theme) and remove the right "settings" icon.
• [x] Remove the ending slash from the urls.
• [x] Remove the "wss://" protocol from the urls and add an icon for ws:// relays - see https://github.com/mikedilger/gossip/issues/702
• [x] Fix horizontal scrolling issue (2024-09-18)
• [ ] Remove the tooltip on the row (it is redundant) (2024-09-18)
• [ ] Add "path:port" if the details option is active (2024-09-21)

Relay details

• [x] Add a little more space below the relay name.
• [x] Move the relay picker rank on the top-left, before the infos.
• [ ] Add "path:port" (2024-09-21)

[bu5hm4nn]

I skipped moving the "Advertise Relays" button for now, because it is also used as a status indicator for the advertisement (it displays "n relays to go"). I think we need a general solution for displaying status of "background tasks".

[dtonon]

Is the realtime update really important for the user? I don't think so. I would keep trace only of the final status, and for this we need to enable the general log view. But it's an optional step.

[mikedilger]

I think we need a general solution for displaying status of "background tasks".

Yes I agree. People don't want to look at terminal logs, but they do want to know if their posts succeeded to the relays they are going to, and when advertise is done, etc.

[dtonon]

@bu5hm4nn there is a scrolling issue with long relay names:

[dtonon]

Yes I agree. People don't want to look at terminal logs, but they do want to know if their posts succeeded to the relays they are going to, and when advertise is done, etc.

I also agree, and we actually have a free slot on the bottom of the sidebar for this. We can show both informative logs (maybe the level can be set by a preference) and the in-progress tasks, putting them on the top with a different style (e.g. a light animation).

But for this specific case, I think that, for now, we can safely avoid showing the user a counter that goes from 250+ to zero.

[bu5hm4nn]

Should be all done on branch

[mikedilger]

Looks good to me, except that the relay path is missing. If relays have a path (which is the exception) it must be shown. I'm fine with wss:// being elided, as well as trailing slashes. But we need the path. I insist.

Gossip picks up a lot of bad relay records. I will try to work on pruning those out. For the moment, you can't identify the bad ones without the path.

[dtonon]

@mikedilger

But we need the path.

I agree. To have a cleaner default view, we can show it (together with the port) when the relay is expanded, like this:

And in the details mode:

What do you think?

[dtonon]

@bu5hm4nn almost perfect, just this notes:

I would further reduce the search width, 8-9 characters seems sufficient to filter the relay list. This way we have more space to show the title when the window is compact.

The tooltips are still present.

The outbox preview box is not always clickable, it have blind spots, you can verify it from the fact that the mouse cursor changes when hovering.

Do we have a neutral (gray) version of the dropdown button? I would prefer it.

I added an item:

• Show the mouse pointer when hovering Relay coverage and Advertise relay list

[mikedilger]

What do you think?

That's ok. As long as it is there.

[dtonon]

That's ok. As long as it is there.

@bu5hm4nn can you that the path/port as proposed?

[bu5hm4nn]

Please re-test the branch. I am not confident enough to remove the tooltip with the full url string, I might have missed some cases (maybe some with arguments).