mikedilger / gossip

Gossip is a nostr client
Other
687 stars 77 forks source link

emoji popup interacts poorly with scrolling #866

Closed mikedilger closed 2 days ago

mikedilger commented 4 days ago

Sometimes you open the emoji picker, and clicking outside of it closes it, but upon scroll it opens up again. It is quite odd.

I played with this for too long but so far failed to get things working.

My attempt (not saved anywhere) made an app.emoji_popup_event: Option<Id> which stores state as to which event has the emoji popup open. Then app.if_scrolling() would set it to None. Then I wanted to tie it into the BarState in ui/feed/note/mod.rs (the code of which looks like it was lifted from egui's menu.rs stationary_menu_impl with rendering variations. But I couldn't figure out how to programmatically open/close the BarState. So then I tried to figure out how to create a popup window area to do the popup from scratch, but even that is beyond me.

I think the emoji_picker (which I moved to a separate file since it was the only "component") should probably be a widget that opens it's own popup area, rather than depending on this crappy egui menu stuff.

mikedilger commented 2 days ago

This is a dup of #830