search

mikedilger / textnonce

Text based random nonce generator
Apache License 2.0
7 stars 8 forks source link

Remove unsafe block in function sized_configured #17

Closed ZephOne closed 5 years ago

ZephOne commented 5 years ago

Would it be possible to get rid of the unsafe block in the function sized_configured and use resize instead ? Is it important that spaces of the vector are not initialized before starting to write into the vector ? I am aware that the unsafe block is totally controlled, it's just to avoid presence of unsafe block.

mikedilger commented 5 years ago

I suppose the performance impact is almost always trivial, so I'd merge it if you submitted a PR.

ZephOne commented 5 years ago

Perfect, I got it on my machine. I fork and submit the PR