search

mikedmor / OctoPrint_MultiCam

Extends the Control tab of OctoPrint, allowing the ability to switch between multiple webcam feeds.
45 stars 19 forks source link

dom ID conflict with main Octoprint UI #47

Closed LazeMSS closed 1 year ago

LazeMSS commented 2 years ago

Your plugin is using the unique ids for the main webcams layers in OctoPrint UI and thereby causing ID conflicts etc.

https://github.com/mikedmor/OctoPrint_MultiCam/blob/355b11398bffcf4987f2f9638498390a0cd404d3/octoprint_multicam/templates/multicam_settings.jinja2#L62

Both: webcam_container and webcam_rotator

OllisGit commented 2 years ago

Hi,

PR #48 fix the issue.

Btw @LazeMSS was there a reported issue?

LazeMSS commented 2 years ago

No I found the bug when trying to add new features in UI Customizer ;)

mikedmor commented 1 year ago

Fixed in version 0.4.0rc3

LazeMSS commented 1 year ago

Thanks