mikedmor / OctoPrint_MultiCam

Extends the Control tab of OctoPrint, allowing the ability to switch between multiple webcam feeds.
45 stars 19 forks source link

Rough setup for OctoPrint 1.9 #54

Closed mikedmor closed 1 year ago

mikedmor commented 1 year ago

Thanks @crysxd. Ill review everything and try to finalize the setup. I appreciate the help. Im merging this into my RC branch to continue. Thank you again for explaining these changes so thoroughly. The documentation might still need a little work for these adjustments on octoprint as its been a bit of a headache figuring everything out.

mikedmor commented 1 year ago

Hey @crysxd,

I have been working on getting some things setup and fixing a few errors that are occurring, but this one has me stuck. It seems to suggest that something is wrong with the webcams. I think it may be due to the current get_webcam_configurations implementation, but cannot quite put a pin in what's causing it. Any input or lights you can shed on what is happening here to help point me in the right direction? Thank you!

Traceback (most recent call last):
  File "/home/mikedmor/oprint/bin/octoprint", line 8, in <module>
    sys.exit(main())
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/__init__.py", line 1008, in main
    octo(args=args, prog_name="octoprint", auto_envvar_prefix="OCTOPRINT")
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/cli/server.py", line 317, in serve_command
    run_server(
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/cli/server.py", line 163, in run_server
    octoprint_server.run()
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/server/__init__.py", line 632, in run
    init_webcam_compat_overlay(self._settings, pluginManager)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/__init__.py", line 578, in init_webcam_compat_overlay
    set_overlay()
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/__init__.py", line 552, in set_overlay
    default_webcam = octoprint.webcams.get_default_webcam(
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/webcams.py", line 67, in get_default_webcam
    return __get_webcam_by_setting("defaultWebcam", fallbackFilter)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/webcams.py", line 78, in __get_webcam_by_setting
    webcams = get_webcams(plugin_manager=plugin_manager)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/webcams.py", line 51, in get_webcams
    octoprint.plugin.call_plugin(
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/plugin/__init__.py", line 267, in call_plugin
    plugins = manager.get_implementations(*types, sorting_context=sorting_context)
  File "/home/mikedmor/oprint/lib/python3.9/site-packages/octoprint/plugin/core.py", line 2176, in get_implementations
    return [impl[1] for impl in sorted(result, key=sort_func)]
TypeError: '<' not supported between instances of 'str' and 'int'
crysxd commented 1 year ago

Yes, I totally forgot about that. I didn't expect you to jump on the branch...sorry!

I'm also at a loss here, I asked on Discord, feel free to chime in!

https://discord.com/channels/704958479194128507/708230829050036236/1111891199519895562