search

mikeebowen / node-wopi-server

A WOPI Server written with Node.js
MIT License
18 stars 4 forks source link

Can you please help me with proof keys implementation #7

Open priyanshumaurya007 opened 6 months ago

priyanshumaurya007 commented 6 months ago

I wanted to extend my sincere appreciation for the invaluable resource your repository has been during my WOPI work.

As I dive into implementing WOPI proof keys, I've noticed some commented-out sections in the code. Could you offer some guidance on how to proceed?

mikeebowen commented 6 months ago

Can you point to which section of the code you're referring?

mikeebowen commented 6 months ago

Hi @priyanshumaurya007, I realized you're referring to the proof keys. Unfortunately, it's commented out, because I haven't completed the implementation. Part of the difficulty is that the wopi-validator-core test for proof keys currently will always fail. There is a PR with a fix here (https://github.com/microsoft/wopi-validator-core/pull/86), but it hasn't been touched in 4 years.