search

mikeerickson / phpunit-pretty-result-printer

PHPUnit Pretty Result Printer -- make your PHPUnit tests look pretty!
MIT License
1.2k stars 71 forks source link

Disable Anybar by default #122

Closed arondeparon closed 5 years ago

arondeparon commented 5 years ago

Our CI systems started generating exceptions when using the 0.20.* build. We downgraded to 0.19.14 and noticed that the error was resolved.

When comparing the differences between these versions, the biggest change is the introduction of Anybar support.

I don't have Anybar installed, and tests seem to be working fine when running them locally on my Mac Os machine, but when running them in our CI environment (Ubuntu), we get unexpected results.

TL;DR: it would probably be wise to disable it by default in the configuration.

See also https://github.com/laravel/framework/issues/6322#issuecomment-425367389

mikeerickson commented 5 years ago

My sincerest apologies, I didn’t know there would be any harm. I will post a new patch today to mark this as false by default

mikeerickson commented 5 years ago

@ArondeParon Hey there, just wanted to let you know, I have tagged a new release 0.21.1 to turn this off by default. Again, my apologies on letting this slip through.

arondeparon commented 5 years ago

No worries @mikeerickson! Can't catch every bug at once! 👍

Thanks for the quick fix.