search

mikeerickson / phpunit-pretty-result-printer

PHPUnit Pretty Result Printer -- make your PHPUnit tests look pretty!
MIT License
1.2k stars 71 forks source link

Phpunit 9.0 compatibility #156

Closed lucacri closed 4 years ago

lucacri commented 4 years ago

Hello, currently this package works only with phpunit ^8.0. Can it be raised to ^9.0?

mikeerickson commented 4 years ago

There are currently issues with PHPUnit 9 as some of the internal classes we’ve extended have been marked as internal so we are waiting for PHPUnit response on how we can work with this issue.

verschuur commented 4 years ago

In PHPUnit 8 the PHPUnit\TextUI\ResultPrinter class was marked as internal, in 9 it has been turned into an interface.

I and a colleague had the same idea for a fix which we implemented for phpunit-pretty-print which seems to fix the issue (albeit at the cost of backwards compatibility). Check out the pull requests https://github.com/sempro/phpunit-pretty-print/pull/30 and https://github.com/sempro/phpunit-pretty-print/pull/29

mikeerickson commented 4 years ago

I have seen this and know what needs to be done to fix it in this project. Just a matter of time to get it implemented

mikeerickson commented 4 years ago

New version 0.27 has been tagged, adding support for PHPUnit 9