chore: Replace string interpolation and dynamic property php8.2 deprecation

mikeerickson / phpunit-pretty-result-printer

PHPUnit Pretty Result Printer -- make your PHPUnit tests look pretty!

MIT License

1.2k stars 71 forks source link

chore: Replace string interpolation and dynamic property php8.2 deprecation #185

Closed anderson-comvex closed 1 month ago

anderson-comvex commented 10 months ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [ ] New feature [X] Other, please explain:

Chore to remove the PHP8.2 Deprecation Warnings.

Screenshot 2023-11-02 at 11 02 09

Screenshot 2023-11-02 at 11 02 27

What changes did you make? (Give an overview)

Replaced ${variable} {$variable}-
Explicitly declared the private variables that were being dynamically declared/

Which issue (if any) does this pull request address?

No Opened Issues

Is there anything you'd like reviewers to focus on?

Not Specifically

acgfbr commented 8 months ago

looks good to me, please merge ✅

vedmant commented 6 months ago

Still open, I made a duplicate PR for this https://github.com/mikeerickson/phpunit-pretty-result-printer/pull/188 any plans to merge this and make a release?

@anderson-comvex Btw, some properties have to be protected, private properties show errors:

Cannot access private property Codedungeon\PHPUnitPrettyResultPrinter\Printer::$anyBarEnabled
error Command failed with exit code 2.

anderson-comvex commented 4 months ago

@vedmant I fixed your comment.

@mikeerickson

anderson-comvex commented 1 month ago

This PR is generating clutter to me as it is not getting merged anytime soons, so i will close it, but feel free to pick the code to apply later if needed.