search

mikeerickson / phpunit-pretty-result-printer

PHPUnit Pretty Result Printer -- make your PHPUnit tests look pretty!
MIT License
1.2k stars 71 forks source link

Set PHP version requirement to 7.1 #53

Closed nikolaposa closed 6 years ago

nikolaposa commented 6 years ago

PHP version requirement should be set to 7.1, as certain features specific for that version are used in some places. For example, void return type is used here: https://github.com/mikeerickson/phpunit-pretty-result-printer/blob/master/src/Printer.php#L160.

mikeerickson commented 6 years ago

The project does indeed support PHP 7.0, we take measures to check what version of PHP Is installed and branch code accordingly.

nikolaposa commented 6 years ago

It happened to me that Composer installed latest version of this library on a PHP 7.0 machine after I required it (composer require --dev codedungeon/phpunit-result-printer) and of course it failed to work due to above mentioned void return type. If PHP version requirement was properly set Composer would not allow me to install it on PHP 7.0.

mikeerickson commented 6 years ago

@nikoloaposa can you please confirm which version you have installed. As of 0.9.x this issue should be resolved. All is working correctly in my testing?

mikeerickson commented 6 years ago

@nikolaposa Hey there, just tagging you again, seems the above message used wrong handle :-)

mikeerickson commented 6 years ago

This has been added to the 0.10.x release, too much hackiness to support PHP 7.0.x

nikolaposa commented 6 years ago

Hi @mikeerickson,

I installed 0.9.3 when I discovered this issue.