search

mikeerickson / phpunit-pretty-result-printer

PHPUnit Pretty Result Printer -- make your PHPUnit tests look pretty!
MIT License
1.2k stars 71 forks source link

Compatibility with PHP Unit 7 ResultsPrinter interface #81

Closed jasonsaayman closed 6 years ago

jasonsaayman commented 6 years ago

Hi

It seems that the Printer.php file is not compatible with the _ResultsPrinter interface in PHP unit 7.

Two functions are affected, that being writeProgress and writeProgressWithColor.

writeProgress changes From: ... protected function writeProgress($progress) ... To: ... protected function writeProgress(string $progress): void ...

writeProgressWithColor changes From: ... protected function writeProgressWithColor($color, $buffer) ... To: ... protected function writeProgressWithColor($color, $buffer): void ...

Thanks

mikeerickson commented 6 years ago

What version of result printer are you using?

mikeerickson commented 6 years ago

Also, what version of PHP and version of PHPUnit

jasonsaayman commented 6 years ago

Hi Mike

Sorry I realized after creating this issue that I was on an older version. Upgrading to the newest version fixed this issue.

Thank you

mikeerickson commented 6 years ago

Awesome, happy to hear. We’ve spent quite a bit of time over last few weeks ironing out all these types of issues, very confident we have addressed them all, thus reason for asking

jasonsaayman commented 6 years ago

No problems :) after upgrading it works like a dream. Thanks for the awesome package!!