search

mikeerickson / phpunit-pretty-result-printer

PHPUnit Pretty Result Printer -- make your PHPUnit tests look pretty!
MIT License
1.2k stars 71 forks source link

Check mark outlining bug #88

Closed roelofjan-elsinga closed 6 years ago

roelofjan-elsinga commented 6 years ago

print bug Hi, I get this outlining. I didn't change any of the default configuration. This is a docker container, running Ubuntu 16.04. I didn't see anything similar in the other issues, so I thought I'd bring this to your attention. If it's a duplicate, you can just remove this.

mikeerickson commented 6 years ago

@roelofjan-elsinga Of course when I attempt to reproduce the issue, all works fine on my end :-( I will continue debugging and try to reproduce.

mikeerickson commented 6 years ago

How are you running these tests? Are you exec into the container, or using something like vessel?

mikeerickson commented 6 years ago

I remember in the past when I was working on some test work for my employer with old tests, there was some code within the test to force line feed after each test (it was actually buried in the TestCase). Any chance there is something like this in your code.

When testing without result printer, does it show normal dots across the screen, or does it also add the line feed?

mikeerickson commented 6 years ago

Are you using Laravel (cant tell for sure based on directory structure) but I am guessing yes.

roelofjan-elsinga commented 6 years ago

I am using Laravel indeed. The tests are run by logging in into the container through docker exec -it container_name bash. I'll get back to you on the default printer. I think I'll also look into TestCase, because I think you may have something there!

roelofjan-elsinga commented 6 years ago

I've looked into the default printing, this also has the newline bug. So I'm assuming it also has to do with the TestCase class in my case. Since this has nothing to do with your printer, I'll close my issue.

roelofjan-elsinga commented 6 years ago

Just in case anyone else gets this behaviour:

You probably have a space or enter after ?> or before <?php. Yes, it's really that simple.

mikeerickson commented 6 years ago

Glad you tracked it down, I had a strong feeling it was something like this (it only because I have experienced it myself as noted)