search

mikefourie-zz / MSBuildExtensionPack

MIT License
366 stars 104 forks source link

Path to targets file in code comment is incorrect #51

Closed eloekset closed 8 years ago

eloekset commented 8 years ago

For instance the Framework\Signing.cs file has XML comments for the class that contains a code sample. In that sample the file MSBuild.ExtensionsPack.tasks is referred to, but in the NuGet package that file is called MSBuild.Extension.Pack.targets in folder [package-folder]\build\net40.

    /// <code lang="xml"><![CDATA[
    /// <Project ToolsVersion="4.0" DefaultTargets="Default" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
    ///     <PropertyGroup>
    ///         <TPath>$(MSBuildProjectDirectory)\..\MSBuild.ExtensionPack.tasks</TPath>
    ///         <TPath Condition="Exists('$(MSBuildProjectDirectory)\..\..\Common\MSBuild.ExtensionPack.tasks')">$(MSBuildProjectDirectory)\..\..\Common\MSBuild.ExtensionPack.tasks</TPath>
    ///     </PropertyGroup>
mikefourie-zz commented 8 years ago

I cant remember why that file is named .target in the nuget packages but the msi installs have the .tasks file. I don't think there's a need to change the samples.