search

mikefourie-zz / MSBuildExtensionPack

MIT License
366 stars 104 forks source link

Version format artificially constraining - e.g. SemVer support #9

Closed jtu100 closed 9 years ago

jtu100 commented 9 years ago

The AssemblyInfo.cs class uses the Version class to parse provided version strings. That severely limits valid inputs, and stops it being compatible with SemVer.

Version class ctor being used forces you to use a 4 component version string for BOTH the AssemblyVersion AND AssemblyFileVersion when in fact neither require this limitation.

The AssemblyVersion should accept anything between 1 and 4 component version. The AssemblyFileVersion is actually free text and you can put anything you want in there.

A way to disable this over specificity would be useful.

mikefourie-zz commented 9 years ago

No argument there and happy to accept a contribution.

Mike

haakoo commented 5 years ago

Just ran into this problem myself now. We'd like to only use a three-part version string for AssemblyVersion. I might have a look at the code and see if I can make a fix.