mikefrederick / MFSideMenu

Facebook-like side menu for iOS
Other
1.17k stars 291 forks source link

Check whether the panning is horizontal before opening side menus #146

Closed luugiathuy closed 10 years ago

luugiathuy commented 10 years ago

Hi Mike,

I have added a check in gestureRecognizerShouldBegin: whether the panning gesture is horizontal panning before handling it. I think it is useful in the case the main view controller has a scroll view, e.g UITableViewController, the panning up and down on the table won't open the side menus.

Again, thank you for your project =)

Cheers, Thuy

Bruno-Furtado commented 10 years ago

@luugiathuy, It's a nice solution, but I believe it can be improved. Use it requires a lot of logic from the controller, no?

You could show an example of this method usage?

luugiathuy commented 10 years ago

@Bruno-Furtado, no logic from your controllers. I changed the logic of MFSideMenuContainerViewController so that it only accepts horizontal gestures

Bruno-Furtado commented 10 years ago

Very good. I used your fork and is a great solution.

Thanks @luugiathuy!

mikefrederick commented 10 years ago

@luugiathuy Thanks for this and sorry I have been a poor maintainer of this project recently.